Subject: Re: [PATCH] Fix e820 end address with EFI
From: Huang Ying <ying.huang@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Brian Maly <bmaly@redhat.com>, Ingo Molnar <mingo@elte.hu>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <49AB4171.7000508@kernel.org>
References: <49A965AD.10701@redhat.com>
	 <86802c440902282014he17bb6an1f59872ef30db0c5@mail.gmail.com>
	 <86802c440902282142p14f623b8td8a88600ff2a6bbe@mail.gmail.com>
	 <49AAEC79.3000808@redhat.com>
	 <1235956068.6204.143.camel@yhuang-dev.sh.intel.com>
	 <49AB38E7.60305@redhat.com>
	 <1235960016.6204.170.camel@yhuang-dev.sh.intel.com>
	 <49AB4171.7000508@kernel.org>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-tAtWhCYuxHILUjgEBEiU"
Date: Mon, 02 Mar 2009 10:25:08 +0800
Message-Id: <1235960708.6204.176.camel@yhuang-dev.sh.intel.com>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2931
Lines: 82


--=-tAtWhCYuxHILUjgEBEiU
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 2009-03-02 at 10:16 +0800, Yinghai Lu wrote:
> Huang Ying wrote:
> > On Mon, 2009-03-02 at 09:39 +0800, Brian Maly wrote:
> >> Huang Ying wrote:=20
> >>> Hi, Brian,
> >>>
> >>> On Mon, 2009-03-02 at 04:13 +0800, Brian Maly wrote:
> >>>  =20
> >>>> I was able verify the kernel that does not boot on the MacBook (vani=
lla=20
> >>>> 2.6.29-rc4) does call efi_ioremap() which bails out early returning=20
> >>>> NULL. So no remapping happens in this case.  I have no idea if=20
> >>>> efi_ioremap ever does succeed in mapping any ranges though being I h=
ave=20
> >>>> no video or console this early in the boot and have to rely on tripl=
e=20
> >>>> faulting as a means of debugging.
> >>>>    =20
> >>> Please attach your dmesg of successful boot, so we can take a look at
> >>> the EFI memory map.
> >>>
> >>> Best Regards,
> >>> Huang Ying
> >>>  =20
> >> This dmesg is from a 2.6.25 kernel which works fine. I can gather
> >> other debugging info from the booting kernels if needed. But its a
> >> challenge to debug the bad kernel being efifb is initialized very late
> >> (so you never even get to the video initialization and cant see any
> >> logged messages) and since its a MacBook I dont have a real serial
> >> port for serial console. The efi map is for MacBook has a different
> >> layout from other EFI systems I have to test on. 2.6.29 kernel works
> >> on every EFI system I have except MacBook.
> >=20
> > It seems that you have an EFI system which has too big runtime area.
> >=20
> > EFI: mem44: type=3D0, attr=3D0x8000000000000000, range=3D[0x000000007ff=
00000-0x0000000080000000) (1MB)
> >=20
> > efi_ioremap() can map only memory range < 400k now.
> >=20
> > It seems that efi_ioremap is the bottle net now. Can we just use
> > init_memory_mapping() instead of efi_ioremap() for EFI runtime area?
> >=20
> > Yinghai, how about your opinion?
>=20
> you could call init_memory_maping() in that efi_ioremap position?
>=20
> problems is how about 32bit?

efi_ioremap() is defined as ioremap_cache() on 32bit system. As that in
arch/x86/include/asm/efi.h.

On 64bit system, efi_ioremap() can be a wrapper for
init_memory_mapping(). Do you think it is appropriate?

Best Regards,
Huang Ying

--=-tAtWhCYuxHILUjgEBEiU
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEABECAAYFAkmrQ34ACgkQKhFGF+eHlphBwQCfXIRZNd9gnlickjAqGBX9A/XD
03kAoKpt08EPXvmXt4IeA6O3rnIBO3IU
=oWUS
-----END PGP SIGNATURE-----

--=-tAtWhCYuxHILUjgEBEiU--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/