Message-ID: <49AB55B9.3050301@oracle.com>
Date: Sun, 01 Mar 2009 19:42:49 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
Organization: Oracle Linux Engineering
User-Agent: Thunderbird 2.0.0.6 (X11/20070801)
MIME-Version: 1.0
To: Cheng Renquan <crquan@gmail.com>
CC: Sam Ravnborg <sam@ravnborg.org>, Roman Zippel <zippel@linux-m68k.org>,
       linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
       cr_quan@163.com
Subject: Re: [PATCH 0/6] [KBUILD] configuration system improvements
References: <1235401804-8136-1-git-send-email-crquan@gmail.com>
In-Reply-To: <1235401804-8136-1-git-send-email-crquan@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1872
Lines: 53

Cheng Renquan wrote:
> This group of patches improve the usability of kernel configuration system,
> mainly,
> 
> 1. add symbol's value shown accompanied in config item's help message;
> 2. move the real plumbing functions code from mconf.c to menu.c, make them
>    be able to be shared with other configuration methods;
> 3. add "symbol's value shown" support for gconfig/xconfig/config;
> 
>   0001--KBUILD-add-symbol-value-to-help-find-the-real-depe.patch
>   0002--KBUILD-add-menu_get_ext_help-function-to-display-m.patch
>   0003--KBUILD-menuconfig-improvements.patch
>   0004--KBUILD-make-use-of-menu_get_ext_help-in-gconfig.patch
>   0005--KBUILD-make-use-of-menu_get_ext_help-in-qconfig.patch
>   0006--KBUILD-make-use-of-menu_get_ext_help-in-make-conf.patch
> 
> I found gconfig still lack of "search by symbol" support, and that would be
> in another patch.
> 
> Request for comments, thanks.

Hi,

I still like this idea a lot.  However, with "make gconfig" I am
seeing a segfault when I click on "Firmware Drivers" in the main menu.
I only see this with these patches applied.

Other than that, they look good to me.


Here's the gconfig info:
rddunlap@chimera:linux-2.6.29-rc6-git5> make ARCH=x86_64 O=xx64 gconfig &
[1] 10722
rddunlap@chimera:linux-2.6.29-rc6-git5>   GEN     /local/linsrc/tmp/linux-2.6.29-rc6-git5/xx64/Makefile
scripts/kconfig/gconf arch/x86/Kconfig
make[2]: *** [gconfig] Segmentation fault
make[1]: *** [gconfig] Error 2
make: *** [sub-make] Error 


and from the kernel log:

gconf[10868]: segfault at 0000000000000070 rip 00000000004111b6 rsp 00007ffff67cd6f0 error 4


Thanks,
-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/