Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755053AbZCBPHc (ORCPT ); Mon, 2 Mar 2009 10:07:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752416AbZCBPHY (ORCPT ); Mon, 2 Mar 2009 10:07:24 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:53253 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337AbZCBPHX (ORCPT ); Mon, 2 Mar 2009 10:07:23 -0500 Date: Mon, 2 Mar 2009 16:10:07 +0100 From: Pavel Machek To: Daniel Mack Cc: linux-kernel@vger.kernel.org, Eric Piel Subject: Re: [PATCH 4/5] lis3: solve dependency between core and ACPI Message-ID: <20090302151007.GM2527@elf.ucw.cz> References: <49ABB22F.7040508@tremplin-utc.net> <1236004310-29196-1-git-send-email-daniel@caiaq.de> <1236004310-29196-2-git-send-email-daniel@caiaq.de> <1236004310-29196-3-git-send-email-daniel@caiaq.de> <1236004310-29196-4-git-send-email-daniel@caiaq.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1236004310-29196-4-git-send-email-daniel@caiaq.de> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 27 Hi! > This solves the dependency between lis3lv02d.[ch] and ACPI specific > methods. It introduces a ->bus_priv pointer to the device struct which > is casted to 'struct acpi_device' in the ACIP layer. Changed hp_accel.c > accordingly. Looks okay to me. I did the basic split but -- having only single client -- did not really have motivation to finish it. > This also moves the read_8() and read_16() routines from hp_accel.c to > lis3lv02d.c as they are not specific to ACPI. These would be slightly better done as separate patch, but I guess its okay... > Signed-off-by: Daniel Mack Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/