Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758849AbZCBSZg (ORCPT ); Mon, 2 Mar 2009 13:25:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752425AbZCBSZ0 (ORCPT ); Mon, 2 Mar 2009 13:25:26 -0500 Received: from mu-out-0910.google.com ([209.85.134.188]:8158 "EHLO mu-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751960AbZCBSZZ (ORCPT ); Mon, 2 Mar 2009 13:25:25 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=c+yflaH/HM2BEAiItYNgPCVXupboC+kiW5iRnu3dAcvB2QBgVfgWmCjQQFCvUHwO8R C1KczYZ3px77PtNEIDyWSn1cOOWP2eEv4FLBaYMB8C9WjaBWhB79/W6g/QJ2DsvlUN/I c9O51rh3I8k2rc3QakJRPvAKCFbd73VGw560s= From: Bartlomiej Zolnierkiewicz To: Peter Zijlstra Subject: Re: [RFC][PATCH] irq: remove IRQF_DISABLED Date: Mon, 2 Mar 2009 19:27:22 +0100 User-Agent: KMail/1.11.0 (Linux/2.6.29-rc6-next-20090227; KDE/4.2.0; i686; ; ) Cc: Linus Torvalds , Ingo Molnar , Thomas Gleixner , lkml , "linux-arch" , Andrew Morton References: <1235996477.5330.174.camel@laptop> <200903021855.02765.bzolnier@gmail.com> <1236017249.5330.1011.camel@laptop> In-Reply-To: <1236017249.5330.1011.camel@laptop> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200903021927.22781.bzolnier@gmail.com> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 29 On Monday 02 March 2009, Peter Zijlstra wrote: > On Mon, 2009-03-02 at 18:55 +0100, Bartlomiej Zolnierkiewicz wrote: > > > Could we make just the IDE driver itself enable interrupts? Sure. But that > > > > Actually it has been doing it for years (some host drivers don't do this by > > default and still need "hdparm -u" or equivalent but I was planning to change > > it for 2.6.30). > > What does it use to do that? A local_irq_enable() in hardirq context > will make lockdep yell bloody murder :-). > > Then there is local_irq_enable_in_hardirq(), which plain simply lies > when lockdep is enabled -- IOW it would generate horrid irq latencies. > > Not having to deal with IRQ recursion in lockdep helps. Lockdep problems are the least of our worries here (please read Linus' original mail for details). If you're asking why it is not handled in softirq -- that's solely because of the historical reasons and I have high hopes w.r.t. threaded IRQs work here [that it will allow us to address this issue without too much pain]. Thanks, Bart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/