Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757713AbZCBS2y (ORCPT ); Mon, 2 Mar 2009 13:28:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751791AbZCBS2p (ORCPT ); Mon, 2 Mar 2009 13:28:45 -0500 Received: from casper.infradead.org ([85.118.1.10]:52450 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbZCBS2o (ORCPT ); Mon, 2 Mar 2009 13:28:44 -0500 Date: Mon, 2 Mar 2009 10:28:41 -0800 From: Arjan van de Ven To: Masami Hiramatsu Cc: Mathieu Desnoyers , Ingo Molnar , Andrew Morton , Nick Piggin , Steven Rostedt , Andi Kleen , linux-kernel@vger.kernel.org, Thomas Gleixner , Peter Zijlstra , Frederic Weisbecker , Linus Torvalds , Rusty Russell , "H. Peter Anvin" , Steven Rostedt Subject: Re: [RFC][PATCH] x86: make text_poke() atomic Message-ID: <20090302102841.7e099670@infradead.org> In-Reply-To: <49AC10E9.1090102@redhat.com> References: <20090223154258.GB28727@Krystal> <20090223161312.GA30279@Krystal> <20090223173108.GB1441@Krystal> <49A82851.5080707@redhat.com> <20090227180724.GA17947@Krystal> <49A83237.40604@redhat.com> <20090227185316.GA19811@Krystal> <49A853CD.3020607@redhat.com> <49AC10E9.1090102@redhat.com> Organization: Intel X-Mailer: Claws Mail 3.7.0 (GTK+ 2.14.7; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 17 > > Use map_vm_area() instead of vmap() in text_poke() for avoiding page > allocation and delayed unmapping, and call vunmap_page_range() and > local_flush_tlb() directly because this mapping is temporary and > local. > > At the result of above change, text_poke() becomes atomic and can be > called from stop_machine() etc. .... but text_poke() realistically needs to call stop_machine() since you can't poke live code.... so that makes me wonder how useful this is... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/