DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to:
	cc:content-type:content-transfer-encoding:x-system-of-record;
	b=SeLNjr5ac6QuHt+iN5r0U8e/ugYdNIPc8W7caOBln07paltyye7jSyoQfT8MNWeVf
	YhsZ4jRPNlmWkc02L3j7g==
MIME-Version: 1.0
In-Reply-To: <20090303090950.60cea53a.kamezawa.hiroyu@jp.fujitsu.com>
References: <49AB40BF.4030706@cn.fujitsu.com>
	 <6599ad830903021019p3b29c173oc7772af6679d90e0@mail.gmail.com>
	 <20090303090950.60cea53a.kamezawa.hiroyu@jp.fujitsu.com>
Date: Mon, 2 Mar 2009 16:15:51 -0800
Message-ID: <6599ad830903021615j6e1380e2l1544b67b187c1f5e@mail.gmail.com>
Subject: Re: [PATCH 0/4] cgroups: show correct file mode
From: Paul Menage <menage@google.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>, Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>,
       Linux Containers <containers@lists.linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 700
Lines: 29

On Mon, Mar 2, 2009 at 4:09 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
>        int mode;
>        if (cft->mode)
>                mode = cft->mode;
>        else if (cft->write_xxx || .....)
>                mode = 0644;
>        else
>                mode = 0444;

Almost:

int mode;
if (cft->mode) {
  mode = cft->mode;
} else {
  if (cft->write_xxx || ....)
    mode |= 0600;
  if (cft->read_xxx || ...)
    mode |= 0444;
}

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/