Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759518AbZCCAT2 (ORCPT ); Mon, 2 Mar 2009 19:19:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752021AbZCCATS (ORCPT ); Mon, 2 Mar 2009 19:19:18 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:58535 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbZCCATS (ORCPT ); Mon, 2 Mar 2009 19:19:18 -0500 Date: Mon, 2 Mar 2009 16:18:26 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Harvey Harrison cc: Andrew Morton , Christoph Hellwig , Geert Uytterhoeven , LKML , Boaz Harrosh Subject: Re: [PATCH 2/2] unaligned: add load/store_{endian}_noalign API In-Reply-To: <1236038818.5756.12.camel@brick> Message-ID: References: <1236038818.5756.12.camel@brick> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 690 Lines: 21 On Mon, 2 Mar 2009, Harvey Harrison wrote: > > Add a typed API with the usual argument ordering and use load/store, > this API is also consistent with the aligned versions. This naming is horrible. It doesn't match the normal pattern we have in the kernel. Why not just try to fix the current (well-named) "get_unaligned_le16()" problems, instead of introducing a new (and badly named) version of them. So NAK on both of these. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/