Date: Tue, 3 Mar 2009 09:55:30 +0100
From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: =?UTF-8?B?SsO2cmc=?= Schummer <ext-jorg.2.schummer@nokia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] MMC: core/core.c: mmc_rescan detects card change in
 one run
Message-ID: <20090303095530.65923117@mjolnir.ossman.eu>
In-Reply-To: <1236065059.5791.34.camel@jorg-desktop>
References: <1235057186-31714-1-git-send-email-ext-jorg.2.schummer@nokia.com>
	<20090302210945.04bfa623@mjolnir.ossman.eu>
	<1236065059.5791.34.camel@jorg-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1181
Lines: 44

On Tue, 03 Mar 2009 09:24:19 +0200
Jörg Schummer <ext-jorg.2.schummer@nokia.com> wrote:

> > 
> > The else section got a bit small here with that code removed. Perhaps
> > we should instead have:
> > 
> > 	if (host->bus_ops != NULL) {
> > 		mmc_bus_put(host);
> > 		goto out;
> > 	}
> 
> I guess you meant
> 
> 	else {
> 		mmc_bus_put(host);
> 		goto out;
> 	}
> 
> since it would be the else clause of
> 
> 	if (host->bus_ops == NULL)
> 

No, I meant to put it further up and unindent the detection code.
Basically you'll be reversing the if-else blocks, but using a goto
instead of an else.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/