Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756153AbZCCKke (ORCPT ); Tue, 3 Mar 2009 05:40:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753425AbZCCKkZ (ORCPT ); Tue, 3 Mar 2009 05:40:25 -0500 Received: from viefep15-int.chello.at ([62.179.121.35]:32292 "EHLO viefep15-int.chello.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753381AbZCCKkY (ORCPT ); Tue, 3 Mar 2009 05:40:24 -0500 X-SourceIP: 213.93.53.227 Subject: Re: lockdep and threaded IRQs (was: ...) From: Peter Zijlstra To: Alan Cox Cc: Ingo Molnar , David Brownell , Andrew Morton , me@felipebalbi.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, felipe.balbi@nokia.com, dmitry.torokhov@gmail.com, sameo@openedhand.com, tglx@linutronix.de In-Reply-To: <20090303103041.0ba4aebd@lxorguk.ukuu.org.uk> References: <1235762883-20870-1-git-send-email-me@felipebalbi.com> <200903021633.08736.david-b@pacbell.net> <20090303004427.GA8638@elte.hu> <200903021837.08635.david-b@pacbell.net> <1236072446.18955.44.camel@twins> <20090303094743.030b2507@lxorguk.ukuu.org.uk> <20090303100329.GA5050@elte.hu> <20090303103041.0ba4aebd@lxorguk.ukuu.org.uk> Content-Type: text/plain Date: Tue, 03 Mar 2009 11:39:58 +0100 Message-Id: <1236076799.22914.31.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 27 On Tue, 2009-03-03 at 10:30 +0000, Alan Cox wrote: > > > So there's no real technical problem here. > > In the long term no - but forcing people to make sudden changes to > critical I/O drivers isn't the right way to do it. My plan is: 1) find all drivers that do not use IRQF_DISABLED 2) add IRQF_LEGACY_ENABLED to those 3) make IRQF_DISABLED 0 and remove its functionality while adding IRQF_LEGACY_ENABLED 4) make request_irq() print a warning for IRQF_LEGACY_ENABLED 5) make an actual IRQF_LEGACY_ENABLED irq firing taint the kernel After that its cleanup time, and I'll try to help out converting some of these to threaded IRQs where appropriate. This will not break any driver, nor force sudden change. Stuff will continue working as expected, just a little more boot noise for those with crappy drivers/hardware. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/