Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756106AbZCCRC7 (ORCPT ); Tue, 3 Mar 2009 12:02:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751984AbZCCRCv (ORCPT ); Tue, 3 Mar 2009 12:02:51 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:33293 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbZCCRCv (ORCPT ); Tue, 3 Mar 2009 12:02:51 -0500 Date: Tue, 3 Mar 2009 12:02:48 -0500 From: Christoph Hellwig To: Felix Blyakher Cc: Eric Sandeen , Christoph Hellwig , Alexander Beregalov , "linux-next@vger.kernel.org" , LKML , xfs@oss.sgi.com Subject: Re: next-20090220: XFS: inconsistent lock state Message-ID: <20090303170248.GA7036@infradead.org> References: <20090224200740.GA9266@infradead.org> <49AD5401.30803@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 19 On Tue, Mar 03, 2009 at 10:57:07AM -0600, Felix Blyakher wrote: > if (lock_flags) { > if (!xfs_ilock_nowait(ip, lock_flags)) { > ASSERT(0); > error = EAGAIN; > goto out_destroy; > } > } > > Or just keep the BUG(); , as it shouldn't happen (we hope). Ok, let's keep the BUG for now and I'll throw in your error undwinding fix. Will resend the series for 2.6.29 patches after QAing them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/