DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=dNWG+Unn2Qq5cH/KjF5xlxi+xKyU0OWp9HT2f64h343Z7etO2vtzQ1JQ3kbMbpz49tyf1EaQytwtpgeoxseOzu//ka67YalGqbxr+qCuzcUG+PWVP6R6+kYEbG8+0aYrG8q/ZiU28aMabo8htzodx30wU0i7Iv1/pqkQnRUM5AU=  ;
From: David Brownell <david-b@pacbell.net>
To: Mike Rapoport <mike@compulab.co.il>
Subject: Re: [PATCH] rtc-v3020: add ability to access v3020 chip with GPIOs
Date: Tue, 3 Mar 2009 13:08:29 -0800
User-Agent: KMail/1.9.10
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>,
       rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, raph@8d.com
References: <cover.1235400430.git.mike@compulab.co.il> <20090302124737.03075958@i1501.lan.towertech.it> <49ABCEB3.6090100@compulab.co.il>
In-Reply-To: <49ABCEB3.6090100@compulab.co.il>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200903031308.29933.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1023
Lines: 39

On Monday 02 March 2009, Mike Rapoport wrote:
> +
> +#define V3020_CS???????0
> +#define V3020_WR???????1
> +#define V3020_RD???????2
> +#define V3020_IO???????3
> +
> +struct v3020_gpio {
> +???????const char *name;
> +???????unsigned int gpio;
> +};
> +

> +static struct v3020_gpio v3020_gpio[] = {
> +???????{ "RTC CS", 0 },
> +???????{ "RTC WR", 0 },
> +???????{ "RTC RD", 0 },
> +???????{ "RTC IO", 0 },
> +};

After Andrew's fault path cleanup it looks OK, but I see
no point to that GPIO struct with the name.  You know the
name based on the position, if you ever need one.  Take
that away, and you can add my ack.


Also, best not to have a single static struct; there's
no need to add a driver restriction that there be only
one of these chips in a system.

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/