Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755787AbZCDAq5 (ORCPT ); Tue, 3 Mar 2009 19:46:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752652AbZCDAqs (ORCPT ); Tue, 3 Mar 2009 19:46:48 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34174 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbZCDAqs (ORCPT ); Tue, 3 Mar 2009 19:46:48 -0500 Date: Wed, 4 Mar 2009 01:49:34 +0100 From: Pavel Machek To: Arve Hj?nnev?g Cc: "Rafael J. Wysocki" , Alan Stern , "Woodruff, Richard" , Arjan van de Ven , Kyle Moffett , Oliver Neukum , Benjamin Herrenschmidt , pm list , LKML , Nigel Cunningham , Matthew Garrett , mark gross , Uli Luckas , Igor Stoppa , Brian Swetland , Len Brown Subject: Re: [RFD] Automatic suspend Message-ID: <20090304004934.GC6280@elf.ucw.cz> References: <200902192215.18365.rjw@sisk.pl> <200903020017.52390.rjw@sisk.pl> <200903032339.02002.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 31 Hi! > > That need not happen at once (eg. in one patch or something). ?Once we've > > introduced the basics, the changes can be made gradually wherever necessary, > > step by step. > > If you are OK with merging an unfinished system then this may work. Good. > > So, I'd suggest to just separate the timeouted suspend blockers from the > > basic code and introduce the latter first. > > How do you want to handle drivers that return -EBUSY from suspend. The > basic code uses a wakelock with a timeout to handle this now. Without > this we can either try suspend again immediately, or activate a > suspend blocker and use a timer to release it. Just printk() and complain. That should be good enough solution for now... (Those drivers are arguably buggy already. If user told machine to go to sleep, it should not randomly refuse to do that.) Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/