DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=ZS5hkiWdlH2xjrC/pLWxWD6uTXh+0ygsfTvFt5KSjklXpDQWDHVMQTNSRQytHaueiL
         O/1zUWA4V8EOp69MRoYGH7VFYnSWfvwn7arlvyu2UbmQH1WQraF+EOhWN4E0DDuFmGb7
         Tzrd2KVCGkaVME/LVPd2xRA0yDwWNB++ZTu3c=
Subject: Re: some tc commands fail on 2.6.29-rc6-git5, works on 2.6.28.7
From: John Dykstra <john.dykstra1@gmail.com>
To: Joao Correia <joaomiguelcorreia@gmail.com>
Cc: Jarek Poplawski <jarkao2@gmail.com>, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org, akpm@linux-foundation.org
In-Reply-To: <a5d9929e0903031510r7f173f5cib7bd1a2426e92473@mail.gmail.com>
References: <a5d9929e0903011636w6bff1032y28ab58c0ff8c8052@mail.gmail.com>
	 <20090301165729.8e08e1d7.akpm@linux-foundation.org>
	 <49AC28FF.1040102@gmail.com>
	 <a5d9929e0903031510r7f173f5cib7bd1a2426e92473@mail.gmail.com>
Content-Type: text/plain
Date: Tue, 03 Mar 2009 20:50:28 -0600
Message-Id: <1236135028.7883.44.camel@Maple>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1486
Lines: 38

On Tue, 2009-03-03 at 23:10 +0000, Joao Correia wrote:
> I have confirmed again that the exact same commands (as on the
> original message), work flawlessly on 2.6.28.7 without a hitch, and,
> AFAIK, work as intended. I have also tried the latest 2.6.29-rc6-git7
> and it still fails like on git6.

I have also reproduced this on Linus' latest 2.6.29-rc6 tree, using tc
version iproute2-ss071016 and a kernel config with all traffic control
features enabled.

The error reported by tc comes from the kernel-level check added by:

	commit c1b56878fb68e9c14070939ea4537ad4db79ffae
	Author: Stephen Hemminger <shemminger@vyatta.com>
	Date:   Tue Nov 25 21:14:06 2008 -0800

    	tc: policing requires a rate estimator

    Found that while trying average rate policing, it was possible to
    request average rate policing without a rate estimator. This results
    in no policing which is harmless but incorrect.

    Since policing could be setup in two steps, need to check
    in the kernel.

    Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

I got the same error when using the tc version iproute2-ss090115 built
this evening from the public git repository.

  -- John

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/