Message-ID: <49AE492F.6020006@atmel.com>
Date: Wed, 04 Mar 2009 10:26:07 +0100
From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Mark Brown <broonie@opensource.wolfsonmicro.com>,
       Jiri Slaby <jirislaby@gmail.com>, linux-input@vger.kernel.org,
       linux-kernel@vger.kernel.org,
       Hans-Christian Egtvedt <hcegtvedt@atmel.com>
Subject: Re: [PATCH 0/5] WM97xx updates
References: <20090303182402.GA29542@rakim.wolfsonmicro.main> <20090304091538.GD7394@dtor-d630.eng.vmware.com>
In-Reply-To: <20090304091538.GD7394@dtor-d630.eng.vmware.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1325
Lines: 34

Dmitry Torokhov wrote:
> On Tue, Mar 03, 2009 at 06:24:03PM +0000, Mark Brown wrote:
>> This patch series updates the review feedback from the first round and
>> rolls in the additional patches from Mike Rapoport.  I've not addressed
>> any of the comments for the at32 driver since I have no ability to test
>> any changes to that driver but repost it for completeness.
>>
> 
> I applied first 4 patches to 'next' and will wait for Hans-Christian
> comments on the at32 driver.
> 

The only thing catched by review was a leaking irq line, do you plan to 
fixup that Mark?

I also think the header file could go into the source code, to make it 
one file less.

Also, please note that I've gotten a new email address. The old one is 
quite annoying since it sends email back about my new address...

I'll not be able to test the driver immediately, my hardware is out at 
customers and the eight new prototypes needs some resoldering before I 
can work with them. Nothing has changed in hardware though, so it should 
fly out of the box.

-- 
Best regards,
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/