Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756031AbZCDLAu (ORCPT ); Wed, 4 Mar 2009 06:00:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750868AbZCDLAl (ORCPT ); Wed, 4 Mar 2009 06:00:41 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:33450 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbZCDLAl (ORCPT ); Wed, 4 Mar 2009 06:00:41 -0500 Date: Wed, 4 Mar 2009 12:00:22 +0100 From: Ingo Molnar To: Brian Maly Cc: Yinghai Lu , linux-kernel@vger.kernel.org, ying.huang@intel.com Subject: Re: [PATCH] fix DMI for EFI Message-ID: <20090304110022.GB18165@elte.hu> References: <49A9F597.4010601@redhat.com> <86802c440902281856h1dc950e7me8568cd5dca59da9@mail.gmail.com> <49ADEDA3.1030406@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49ADEDA3.1030406@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 39 * Brian Maly wrote: > New patch. Its easier I think to just move efi_init() earlier. Seems > less risky and less drawbacks. > > Signed-off-by: Brian Maly > > > setup.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > > --- a/arch/x86/kernel/setup.c 2009-03-03 21:24:53.000000000 -0500 > +++ b/arch/x86/kernel/setup.c 2009-03-03 21:26:00.000000000 -0500 > @@ -770,6 +770,9 @@ void __init setup_arch(char **cmdline_p) > > finish_e820_parsing(); > > + if (efi_enabled) > + efi_init(); > + > dmi_scan_machine(); Hm, could we ever find ourselves in the positition of having to access the DMI strings table in the EFI init code, to implement a quirk? I think that's quite plausible. OTOH, with some DMI quirks in EFI tables it's a bit of a chicken and egg problem. Can DMI strings ever be outside of EFI tables on EFI systems? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/