Date: Wed, 4 Mar 2009 18:51:22 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Daniel =?iso-8859-1?Q?Gl=F6ckner?= <dg@emlix.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
       Suresh Siddha <suresh.b.siddha@intel.com>,
       "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
       Arjan van de Ven <arjan@infradead.org>, x86@kernel.org,
       Bill Metzenthen <billm@melbpc.org.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, math-emu: fix init_fpu for task != current
Message-ID: <20090304175122.GA29823@elte.hu>
References: <E1Le9vp-00020J-AA@mailer.emlix.com> <20090302195230.GA12252@elte.hu> <E1LetWv-0002Kq-Sq@mailer.emlix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <E1LetWv-0002Kq-Sq@mailer.emlix.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1501
Lines: 43


* Daniel Gl?ckner <dg@emlix.com> wrote:

> On 03/02/2009 08:52 PM, Ingo Molnar wrote:
> > * Daniel Gl?ckner <dg@emlix.com> wrote:
> [..]
> >> This patch creates a new function finit_task that takes a task_struct
> >> parameter. finit becomes a wrapper that simply calls finit_task with
> >> current. On the plus side this avoids many calls to get_current which
> >> would each resolve to an inline assembler mov instruction.
> [..]
> >> --- a/arch/x86/kernel/i387.c
> >> +++ b/arch/x86/kernel/i387.c
> >> @@ -136,7 +136,7 @@ int init_fpu(struct task_struct *tsk)
> >>  #ifdef CONFIG_X86_32
> >>  	if (!HAVE_HWFP) {
> >>  		memset(tsk->thread.xstate, 0, xstate_size);
> >> -		finit();
> >> +		finit_task(tsk);
> >>  		set_stopped_child_used_math(tsk);
> >>  		return 0;
> >>  	}
> [..]
> > 
> > ok, the fix looks good - but we sure want to define this 
> > function in the "# CONFIG_MATH_EMU is not set" case too, agreed?
> 
> To avoid linker errors if the compiler emits the call although 
> !HAVE_HWFP is always false? Sounds plausible. I also removed 
> finit from i387.h as the only other external call site, 
> reg_ld_str.c, gets its prototype from fpu_proto.h.

Could you please send a single combo patch with a full 
changelog, etc.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/