Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754733AbZCEIF7 (ORCPT ); Thu, 5 Mar 2009 03:05:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751948AbZCEIFu (ORCPT ); Thu, 5 Mar 2009 03:05:50 -0500 Received: from mtagate1.uk.ibm.com ([194.196.100.161]:52482 "EHLO mtagate1.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbZCEIFt (ORCPT ); Thu, 5 Mar 2009 03:05:49 -0500 Message-ID: <49AF87D6.5040104@linux.vnet.ibm.com> Date: Thu, 05 Mar 2009 09:05:42 +0100 From: Frank Blaschka User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Patrick McHardy CC: David Miller , bart@jukie.net, greearb@candelatech.com, shemminger@vyatta.com, dada1@cosmosbay.com, frank.blaschka@de.ibm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUG] 2.6.29-rc* QinQ vlan trunking regression References: <49AF79A6.6030002@trash.net> <20090304.231120.86999183.davem@davemloft.net> <49AF7B72.2020905@trash.net> <20090304.231911.213286076.davem@davemloft.net> <49AF7E93.2010800@trash.net> <49AF7FD3.5010709@trash.net> In-Reply-To: <49AF7FD3.5010709@trash.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1350 Lines: 44 Hi Dave, Patrick, sorry I could not follow the complete discussion of the fixes done for this problem but does if (netif_device_present(real_dev) && ops->ndo_neigh_setup) - err = ops->ndo_neigh_setup(dev, pa); + err = ops->ndo_neigh_setup(real_dev, pa); not change the idea of the neigh_setup? Remind we want the neigh_setup of the real device as the neigh setup function for the vlan device. Frank Patrick McHardy schrieb: > Patrick McHardy wrote: >> David Miller wrote: >>> From: Patrick McHardy >>> Date: Thu, 05 Mar 2009 08:12:50 +0100 >>> >>>>> We probably need both fixes to cover everything. >>>>> >>>> Yes, just the second one still crashes. I'm about to retry using both. >>> >>> Here is the updated version just for the record: >>> >>> vlan: Fix vlan-in-vlan crashes. >> >> This still crashes. I'll have another look at the code. > > This one combined with your patch fixes the crash. The code was calling > vlan_dev_neigh_setup recursively. > > Signed-off-by: Patrick McHardy > > (or Tested-by: in case you want to roll it into your patch). > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/