Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755997AbZCEPrp (ORCPT ); Thu, 5 Mar 2009 10:47:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751737AbZCEPrg (ORCPT ); Thu, 5 Mar 2009 10:47:36 -0500 Received: from e3.ny.us.ibm.com ([32.97.182.143]:59474 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753321AbZCEPrf (ORCPT ); Thu, 5 Mar 2009 10:47:35 -0500 Date: Thu, 5 Mar 2009 07:47:30 -0800 From: "Darrick J. Wong" To: Jean Delvare Cc: Andrew Morton , linux-kernel , lm-sensors Subject: Re: [PATCH] lm90: Support the MAX6648/6692 chips Message-ID: <20090305154729.GL6550@plum> Reply-To: djwong@us.ibm.com References: <20090302210106.GD6550@plum> <20090305152517.4e0b8983@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090305152517.4e0b8983@hyperion.delvare> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2453 Lines: 47 On Thu, Mar 05, 2009 at 03:25:17PM +0100, Jean Delvare wrote: > Hi Darrick > I am confused. According to my notes, the MAX6648/MAX6692 is the same > chip as the MAX6646/MAX6647/MAX6649 (same chip ID of 0x59), the only > difference being the I2C address (0x4c for the MAX6646, 0x4e for the > MAX6647 and 0x4d for the MAX6648/MAX6649/MAX6692). So the current code > should _already_ detect your MAX6648 or MAX6692 as kind = max6646. Heh, yep, it does. I guess this patch has been sitting around long enough to become obsolete, sorry for the unnecessary mail traffic. I guess we can drop this one. > Can you please test the latest version of the sensors-detect script [1] > and let me know if your chip is properly detected? If not, please > provide a dump of your chip. Just for fun, here's a dump of that chip (6648): No size specified (using byte-data access) 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef 00: 15 1d 00 00 05 69 00 6e 05 05 05 05 05 05 05 05 ??..?i.n???????? 10: e0 c0 c0 c0 c0 c0 c0 c0 00 91 91 91 91 91 91 91 ????????.??????? 20: 91 0a 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 30: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 40: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 50: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 60: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 70: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 80: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? 90: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? a0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? b0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? c0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? d0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? e0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 86 ???????????????? f0: 86 86 86 86 86 86 86 86 86 86 86 86 86 86 4d 59 ??????????????MY > [1] http://www.lm-sensors.org/svn/lm-sensors/trunk/prog/detect/sensors-detect This also detects it properly. --D -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/