Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756442AbZCEUGG (ORCPT ); Thu, 5 Mar 2009 15:06:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755099AbZCEUFw (ORCPT ); Thu, 5 Mar 2009 15:05:52 -0500 Received: from accolon.hansenpartnership.com ([76.243.235.52]:45727 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753028AbZCEUFv (ORCPT ); Thu, 5 Mar 2009 15:05:51 -0500 Subject: Re: [PATCH v2 09/15] NULL noise: drivers/scsi/FlashPoint.c From: James Bottomley To: Hannes Eder Cc: trivial@kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi In-Reply-To: <20090305191602.30062.71301.stgit@f10box.hanneseder.net> References: <20090305190954.30062.44759.stgit@f10box.hanneseder.net> <20090305191602.30062.71301.stgit@f10box.hanneseder.net> Content-Type: text/plain Date: Thu, 05 Mar 2009 20:05:46 +0000 Message-Id: <1236283546.5626.45.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2107 Lines: 53 On Thu, 2009-03-05 at 20:16 +0100, Hannes Eder wrote: > Fix this sparse warnings: > drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer > drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer > drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer > > Signed-off-by: Hannes Eder > --- > v2: fix checkpatch.pl issue. > v2.1: other subject, as suggested by Al Viro > > drivers/scsi/FlashPoint.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c > index b898d38..9eb2e86 100644 > --- a/drivers/scsi/FlashPoint.c > +++ b/drivers/scsi/FlashPoint.c > @@ -903,8 +903,8 @@ static void FPT_autoCmdCmplt(unsigned long p_port, unsigned char p_card); > static void FPT_autoLoadDefaultMap(unsigned long p_port); > > static struct sccb_mgr_tar_info FPT_sccbMgrTbl[MAX_CARDS][MAX_SCSI_TAR] = > L- { {{0}} }; > -static struct sccb_card FPT_BL_Card[MAX_CARDS] = { {0} }; > + { { {NULL} } }; > +static struct sccb_card FPT_BL_Card[MAX_CARDS] = { {NULL} }; > static SCCBSCAM_INFO FPT_scamInfo[MAX_SCSI_TAR] = { {{0}} }; > static struct nvram_info FPT_nvRamInfo[MAX_MB_CARDS] = { {0} }; This doesn't look right: {0} as a structure initialiser is a C convention for zero fill this structure; sparse should recognise this. Of course, since these structures are static, they should be in BSS anyway ... > @@ -918,8 +918,7 @@ static unsigned char FPT_scamHAString[] = > > static unsigned short FPT_default_intena = 0; > > -static void (*FPT_s_PhaseTbl[8]) (unsigned long, unsigned char) = { > -0}; > +static void (*FPT_s_PhaseTbl[8]) (unsigned long, unsigned char) = {NULL}; > > /*--------------------------------------------------------------------- > * James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/