Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751707AbZCEV3i (ORCPT ); Thu, 5 Mar 2009 16:29:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752617AbZCEV31 (ORCPT ); Thu, 5 Mar 2009 16:29:27 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:47176 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbZCEV30 (ORCPT ); Thu, 5 Mar 2009 16:29:26 -0500 Date: Thu, 5 Mar 2009 16:29:20 -0500 From: Christoph Hellwig To: Hannes Eder Cc: Christoph Hellwig , Felix Blyakher , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com Subject: Re: [PATCH 3/3 v2] xfs: include header files for prototypes Message-ID: <20090305212920.GA1883@infradead.org> References: <20090304183136.525.13769.stgit@f10box.hanneseder.net> <20090304183418.525.22262.stgit@f10box.hanneseder.net> <20090305133917.GC14854@lst.de> <20090305141912.22775.64010.stgit@f10box.hanneseder.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090305141912.22775.64010.stgit@f10box.hanneseder.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 14 On Thu, Mar 05, 2009 at 03:20:25PM +0100, Hannes Eder wrote: > I still treat this as a Acked-by: ... Ok? Should be a review, as far as you can review these sort of patches.. > hm. but that way it is still included before xfs_mount.h. Sure, but the point is entirely the comment which describes the block of includes below. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/