Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755171AbZCFJ7n (ORCPT ); Fri, 6 Mar 2009 04:59:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751324AbZCFJ7c (ORCPT ); Fri, 6 Mar 2009 04:59:32 -0500 Received: from gate.crashing.org ([63.228.1.57]:49287 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbZCFJ7b (ORCPT ); Fri, 6 Mar 2009 04:59:31 -0500 Subject: Re: [RFC][PATCH] irq: remove IRQF_DISABLED From: Benjamin Herrenschmidt To: Peter Zijlstra Cc: Linus Torvalds , Ingo Molnar , Thomas Gleixner , lkml , linux-arch , Andrew Morton In-Reply-To: <1236330733.6326.15.camel@laptop> References: <1235996477.5330.174.camel@laptop> <1236329922.7260.127.camel@pasglop> <1236330733.6326.15.camel@laptop> Content-Type: text/plain Date: Fri, 06 Mar 2009 20:59:03 +1100 Message-Id: <1236333543.7260.138.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 36 > If you have distinct interrupt priorities, you can > > 1) provide an interrupt stack for each priority > 2) mask all lower priorities when handling one > > Would that not work? The PIC does that already. IE. it will only interrupt again before ->eoi() for an interrupt of a higher priority. But by using IRQF_DISABLED, you mask interrupts in the core, and thus effectively completely prevents the whole thing. > The problems with enabling irqs in hardirq handlers are that you get > unlimited irq nesting, which is bad for your stack, furthermore, somehow > people thing it makes things 'faster' because the irq-off latency goes > down. No, you don't get unlimited IRQ nesting, at least not on sane archs with a decent PIC that does things like what I described above :-) > The latter just isn't true, as you still have preemption disabled, so > everything but irqs still suffers. > > The only way to make things low-latency is to pull work out of > non-preemptable context. Using threaded IRQs is one way to do that. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/