Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755032AbZCFLNc (ORCPT ); Fri, 6 Mar 2009 06:13:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752724AbZCFLNX (ORCPT ); Fri, 6 Mar 2009 06:13:23 -0500 Received: from mba.ocn.ne.jp ([122.1.235.107]:62449 "EHLO smtp.mba.ocn.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbZCFLNW (ORCPT ); Fri, 6 Mar 2009 06:13:22 -0500 Date: Fri, 06 Mar 2009 20:13:19 +0900 (JST) Message-Id: <20090306.201319.95063735.anemo@mba.ocn.ne.jp> To: dan.j.williams@intel.com Cc: thierry.reding@avionic-design.de, haavard.skinnemoen@atmel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dmaengine: Fix oops on dmatest module unload. From: Atsushi Nemoto In-Reply-To: References: <1234441811-9628-1-git-send-email-thierry.reding@avionic-design.de> X-Fingerprint: 6ACA 1623 39BD 9A94 9B1A B746 CA77 FE94 2874 D52F X-Pgp-Public-Key: http://wwwkeys.pgp.net/pks/lookup?op=get&search=0x2874D52F X-Mailer: Mew version 5.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 16 On Wed, 4 Mar 2009 16:03:47 -0700, Dan Williams wrote: > ...and now it is unapplied :-). The problem with this patch is that > it releases the channel before dmatest is done with it. 'Cleanup' > followed by 'release' is the right order, just need to save ->chan > before it gets freed. Oh that's right. I tested your fix in async_tx tree and it works fine. Thanks! --- Atsushi Nemoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/