Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756782AbZCFQYf (ORCPT ); Fri, 6 Mar 2009 11:24:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751750AbZCFQYY (ORCPT ); Fri, 6 Mar 2009 11:24:24 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:43681 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbZCFQYY (ORCPT ); Fri, 6 Mar 2009 11:24:24 -0500 Date: Fri, 6 Mar 2009 17:24:02 +0100 From: Ingo Molnar To: Daniel Yeisley , Yinghai Lu , "H. Peter Anvin" , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] MSI: check for BIOS assigned addresses Message-ID: <20090306162402.GA8936@elte.hu> References: <1236352309.31604.2.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1236352309.31604.2.camel@localhost.localdomain> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 19 * Daniel Yeisley wrote: > When creating MSI addresses the kernel makes them up and > writes them to the hardware without first checking for what > the system BIOS may have assigned. The patch below checks for > already assigned values, and leaves them alone if they exist. > > Signed-off-by: Dan Yeisley What happens without this fix - do you get non-working cards? Boot hang? Or a suboptimal layout? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/