Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756396AbZCFSVa (ORCPT ); Fri, 6 Mar 2009 13:21:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754013AbZCFSVV (ORCPT ); Fri, 6 Mar 2009 13:21:21 -0500 Received: from casper.infradead.org ([85.118.1.10]:41875 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752983AbZCFSVV (ORCPT ); Fri, 6 Mar 2009 13:21:21 -0500 Subject: Re: [Patch] mm tracepoints From: Peter Zijlstra To: Ingo Molnar Cc: Larry Woodman , Andrew Morton , Nick Piggin , Steven Rostedt , KOSAKI Motohiro , linux-kernel@vger.kernel.org, fweisbec@gmail.com In-Reply-To: <20090306180154.GA20292@elte.hu> References: <1236291400.1476.50.camel@dhcp-100-19-198.bos.redhat.com> <20090306105627.3EF0.A69D9226@jp.fujitsu.com> <20090306110423.GD21168@elte.hu> <1236342797.3154.1.camel@dhcp47-138.lab.bos.redhat.com> <20090306135547.GB21907@elte.hu> <1236358657.1476.56.camel@dhcp-100-19-198.bos.redhat.com> <20090306171016.GA32128@elte.hu> <1236361106.6326.595.camel@laptop> <1236362197.6326.615.camel@laptop> <20090306180154.GA20292@elte.hu> Content-Type: text/plain Date: Fri, 06 Mar 2009 19:20:25 +0100 Message-Id: <1236363625.6326.641.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.25.92 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 31 On Fri, 2009-03-06 at 19:01 +0100, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > > On Fri, 2009-03-06 at 18:38 +0100, Peter Zijlstra wrote: > > > On Fri, 2009-03-06 at 18:10 +0100, Ingo Molnar wrote: > > > > Looks pretty good and useful to me. I've Cc:-ed more mm folks, > > > > it would be nice to hear their opinion about these tracepoints. > > > > > > > > Andrew, Nick, Peter, what do you think? > > > > > > Bit sad we use the struct mm_struct * as mm identifier (little %lx vs %p > > > confusion there too), but I suppose there simply isn't anything better. > > > > > Things missing, > > > > Why only anon and filemap, that misses out on all the funky > > driver ->fault() handlers. > > btw., does it include shm faults? I think all of this would be > handled if the tracepoint was at handle_mm_fault(), right? Partially, you wouldn't be able to do the file:offset thing you asked for. But yeah, also hugetlb seems to be missing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/