Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756849AbZCGBHf (ORCPT ); Fri, 6 Mar 2009 20:07:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754911AbZCGBHZ (ORCPT ); Fri, 6 Mar 2009 20:07:25 -0500 Received: from hera.kernel.org ([140.211.167.34]:54561 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753655AbZCGBHY (ORCPT ); Fri, 6 Mar 2009 20:07:24 -0500 Message-ID: <49B1C884.2020301@kernel.org> Date: Fri, 06 Mar 2009 17:06:12 -0800 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Ingo Molnar CC: Daniel Yeisley , mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, stable@kernel.org, tglx@linutronix.de, linux-pci@vger.kernel.org Subject: Re: [tip:x86/apic] x86: MSI: check for BIOS assigned addresses References: <1236352309.31604.2.camel@localhost.localdomain> <20090306184514.GC15526@elte.hu> <1236364109.31604.10.camel@localhost.localdomain> <20090306191345.GD28582@elte.hu> In-Reply-To: <20090306191345.GD28582@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1792 Lines: 45 Ingo Molnar wrote: > * Daniel Yeisley wrote: > >> On Fri, 2009-03-06 at 19:45 +0100, Ingo Molnar wrote: >>> * Daniel Yeisley wrote: >>> >>>> Commit-ID: affd49d36e2e2df4cbb3e07a57db901c23823b6a >>>> Gitweb: http://git.kernel.org/tip/affd49d36e2e2df4cbb3e07a57db901c23823b6a >>>> Author: "Daniel Yeisley" >>>> AuthorDate: Fri, 6 Mar 2009 10:11:49 -0500 >>>> Commit: Ingo Molnar >>>> CommitDate: Fri, 6 Mar 2009 19:32:44 +0100 >>>> >>>> x86: MSI: check for BIOS assigned addresses >>>> >>>> Impact: fix ACPI hotplug on certain systems >>> Note, this commit means that i moved the commit over from >>> tip:x86/urgent into tip:x86/apic - i.e. with a 2.6.30 merge >>> date. When exactly was this regression introduced? I think this >>> code never really accepted the MSI settings from the firmware, >>> so changing that behavior might affect a lot of systems. >>> >>> So i'm uneasy about applying this fix this late in the .29 >>> cycle, but marked it for -stable backport so it could hit >>> 2.6.29.1 if it stays problem-free. >>> >>> Ingo >> I initially noticed the problem on a 2.6.18 kernel. ACPI >> hotplugging didn't work unless I booted with pci=nomsi. I >> don't have a problem with waiting until 2.6.30 to make sure it >> is thoroughly tested. > > Okay - so it's an ancient bug. The current track should thus be > fine. > please drop this patch. it seems it break msi-x. at least igbe with msi-x does not work anymore. YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/