Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752863AbZCGHSh (ORCPT ); Sat, 7 Mar 2009 02:18:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751385AbZCGHSZ (ORCPT ); Sat, 7 Mar 2009 02:18:25 -0500 Received: from rv-out-0506.google.com ([209.85.198.236]:4775 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbZCGHSZ convert rfc822-to-8bit (ORCPT ); Sat, 7 Mar 2009 02:18:25 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=N6+stPgVsZzdeEIfsQAMcZsd2eJhEMLwnCYGO7KLLF0FmaLazjL/FkobSRuN5mVlX4 RgraU/yQxtSKa/swW+/Ox5zJkZz0uQGI2xCG0FTnUXH6ta0/CZ15IFIs3gewDkT4qkKf JbudL+UxfGMH6P+zcFd45O1RstvgTtlCuCY9s= MIME-Version: 1.0 In-Reply-To: <49B1F934.5050006@kernel.org> References: <49B1F934.5050006@kernel.org> Date: Fri, 6 Mar 2009 23:18:22 -0800 Message-ID: <4807377b0903062318q15ba52a7n82d4c9399b8a7fa8@mail.gmail.com> Subject: Re: [PATCH] igb: fix kexec with igb From: Jesse Brandeburg To: Yinghai Lu Cc: David Miller , "Rafael J. Wysocki" , Ingo Molnar , Andrew Morton , "linux-kernel@vger.kernel.org" , NetDev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 33 On Fri, Mar 6, 2009 at 8:33 PM, Yinghai Lu wrote: > > Impact: could probe igb > > Found one system with 82575EB, in the kernel that is kexeced, probe igb > failed with -2. > > it looks like the same behavior happened on forcedeth. > > try to check system_state to make sure if put it on D3 > > Signed-off-by: Yinghai Lu > > --- > ?drivers/net/igb/igb_main.c | ? 19 ++++++++++++++----- > ?1 file changed, 14 insertions(+), 5 deletions(-) I see the point of the patch, but I know for a fact that ixgbe when enabled for MSI-X also doesn't work with kexec. so my questions are: are you going to change every driver? why can't this be fixed in core kernel code instead? Shouldn't pci_enable_device take it out of D3? Or maybe it should be taken out of D3 immediately if someone tries to ioremap any of the BARx registers? Jesse -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/