Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756216AbZCGTwK (ORCPT ); Sat, 7 Mar 2009 14:52:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753516AbZCGTv4 (ORCPT ); Sat, 7 Mar 2009 14:51:56 -0500 Received: from mtagate2.uk.ibm.com ([194.196.100.162]:35999 "EHLO mtagate2.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755273AbZCGTv4 (ORCPT ); Sat, 7 Mar 2009 14:51:56 -0500 Subject: Re: [PATCH 0/7][v8] Container-init signal semantics From: Greg Kurz To: Daniel Lezcano Cc: Sukadev Bhattiprolu , Andrew Morton , linux-kernel@vger.kernel.org, "Eric W. Biederman" , Containers , Oleg Nesterov , roland@redhat.com In-Reply-To: <49B2CE6E.3090501@free.fr> References: <20090219030207.GA18783@us.ibm.com> <499D73C8.3090209@free.fr> <20090307190428.GA30594@us.ibm.com> <49B2CE6E.3090501@free.fr> Content-Type: text/plain Date: Sat, 07 Mar 2009 20:51:49 +0100 Message-Id: <1236455509.9151.4.camel@bahia> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1489 Lines: 43 On Sat, 2009-03-07 at 20:43 +0100, Daniel Lezcano wrote: > case LINUX_REBOOT_CMD_HALT: > - kernel_halt(); > - unlock_kernel(); > - do_exit(0); > + if (power_off_pid_ns(current->nsproxy->pid_ns)) { > + kernel_halt(); > + unlock_kernel(); > + do_exit(0); > + } Even if current will get SIGKILLed when zap_pid_ns_processes() is called, I see no reason it doesn't call do_exit(0). > break; > > case LINUX_REBOOT_CMD_POWER_OFF: > - kernel_power_off(); > - unlock_kernel(); > - do_exit(0); > + if (power_off_pid_ns(current->nsproxy->pid_ns)) { > + kernel_power_off(); > + unlock_kernel(); > + do_exit(0); > + } Same. > break; > -- Gregory Kurz gkurz@fr.ibm.com Software Engineer @ IBM/Meiosys http://www.ibm.com Tel +33 (0)534 638 479 Fax +33 (0)561 400 420 "Anarchy is about taking complete responsibility for yourself." Alan Moore. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/