From: Roland Dreier <rdreier@cisco.com>
To: Adrian McMenamin <lkmladrian@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: printk issue - bug?
References: <8b67d60903071537p10994257obc7cce99028a740c@mail.gmail.com>
Date: Sat, 07 Mar 2009 15:52:23 -0800
In-Reply-To: <8b67d60903071537p10994257obc7cce99028a740c@mail.gmail.com>
	(Adrian McMenamin's message of "Sat, 7 Mar 2009 23:37:15 +0000")
Message-ID: <adaab7wgabs.fsf@cisco.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 890
Lines: 24

 > printk("PAGE_SIZE is 0x%X\n", PAGE_SIZE);
 > printk("Offset is 0x%X, PAGE_SIZE is 0x%X, readlen is 0x%X\n", offset,
 > PAGE_SIZE, readlen)
 > 
 > Output is:
 > 
 > [  162.603348] PAGE_SIZE is 0x1000
 > [  162.607473] Offset is 0x0, PAGE_SIZE is 0x0, readlen is 0x1000
 > 
 > ie PAGE_SIZE is incorrectly reported in the second printk (these are
 > consecutive lines of code)
 > 
 > offset is loff_t and readlen is unsigned long.

ie offset is a 64-bit type but the printk format for it is %x, which
presumably only consumes 32 bits on SH4?  Seems like your code is buggy
and you ignored a compiler warning about printk format mismatch?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/