Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751857AbZCHMhZ (ORCPT ); Sun, 8 Mar 2009 08:37:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751294AbZCHMhK (ORCPT ); Sun, 8 Mar 2009 08:37:10 -0400 Received: from netrider.rowland.org ([192.131.102.5]:49286 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751256AbZCHMhJ (ORCPT ); Sun, 8 Mar 2009 08:37:09 -0400 Date: Sun, 8 Mar 2009 08:37:02 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: "Rafael J. Wysocki" cc: Jeremy Fitzhardinge , LKML , Jesse Barnes , Thomas Gleixner , "Eric W. Biederman" , Ingo Molnar , Linus Torvalds , pm list , Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= Subject: Re: [linux-pm] [RFC][PATCH][1/8] PM: Rework handling of interrupts during suspend-resume (rev. 5) In-Reply-To: <200903081100.43757.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 26 On Sun, 8 Mar 2009, Rafael J. Wysocki wrote: > > > > So perhaps you're worried about drivers that aren't sufficiently > > > > clever. Or is something deeper going on? > > In other words, why not simply abort the suspend if IRQ_PENDING is set > > for _any_ interrupt during sysdev_suspend()? > > The "wake-up" ones are _intentionally_ left enabled, while the other ones may > be left enabled by mistake. The check is intended to prevent the current > behavior from changing (ie. suspend is aborted if any "wake-up" interrupts > are pending) and since the platforms only check for the "wake-up" interrupts, > it doesn't go any further. Moreover, I think it might introduce a regression > if it did. So it _is_ because you are worried about drivers that aren't sufficiently clever. If the drivers did their job correctly then there wouldn't be any pending non-"wake-up" interrupts to confuse matters. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/