Date: Mon, 9 Mar 2009 12:41:31 -0600
From: Alex Chiang <achiang@hp.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Matthew Wilcox <matthew@wil.cx>, Greg KH <greg@kroah.com>,
       kay.sievers@vrfy.org, rjw@sisk.pl, linux-kernel@vger.kernel.org,
       linux-pci@vger.kernel.org
Subject: Re: kobj refcounting weirdness
Message-ID: <20090309184131.GI32589@ldl.fc.hp.com>
Mail-Followup-To: Alex Chiang <achiang@hp.com>,
	Vegard Nossum <vegard.nossum@gmail.com>,
	Matthew Wilcox <matthew@wil.cx>, Greg KH <greg@kroah.com>,
	kay.sievers@vrfy.org, rjw@sisk.pl, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
References: <20090309063654.GB23137@ldl.fc.hp.com> <20090309150453.GB7627@kroah.com> <20090309165010.GB32589@ldl.fc.hp.com> <20090309165807.GU25995@parisc-linux.org> <20090309180143.GG32589@ldl.fc.hp.com> <19f34abd0903091121g73d6cdeeqfa8353b55a3e9607@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <19f34abd0903091121g73d6cdeeqfa8353b55a3e9607@mail.gmail.com>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1394
Lines: 37

* Vegard Nossum <vegard.nossum@gmail.com>:
> 2009/3/9 Alex Chiang <achiang@hp.com>:
> > * Matthew Wilcox <matthew@wil.cx>:
> >> On Mon, Mar 09, 2009 at 10:50:10AM -0600, Alex Chiang wrote:
> >> > I thought about the allocators returning a pointer to the same
> >> > location that maybe has some valid looking data hanging around,
> >> > but it's not wise for someone like me to go pointing fingers at
> >> > the allocator before I've proven the bug isn't in my code. ;)
> >>
> >> Slab poisoning would be the logical next thing to try to decide whether
> >> the allocator is wrong or you're using it wrong ;-)
> >
> > We had a double free in the PCIe port driver. Removing the double
> > free seems to fix my issue.
> >
> > The double free is only in Jesse's linux-next branch, so no need
> > to worry about it in mainline/stable.
> 
> Sorry for butting in, just wondering if I could have the patch to fix
> the double free? :-)

http://thread.gmane.org/gmane.linux.kernel.pci/3524

Remember, it only applies to Jesse's linux-next, since it has
Rafael's latest port driver cleanups.

If you apply it to mainline, you will leak memory.

Thanks.

/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/