Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754270AbZCJAwT (ORCPT ); Mon, 9 Mar 2009 20:52:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751512AbZCJAwH (ORCPT ); Mon, 9 Mar 2009 20:52:07 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:47301 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbZCJAwF (ORCPT ); Mon, 9 Mar 2009 20:52:05 -0400 Date: Mon, 9 Mar 2009 20:52:00 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Frederic Weisbecker cc: Ingo Molnar , LKML , Lai Jiangshan , Peter Zijlstra , Mathieu Desnoyers , Jiaying Zhang , Martin Bligh Subject: Re: [RFC][PATCH 1/2] tracing/ftrace: syscall tracing infrastructure In-Reply-To: <20090309204748.GD5010@nowhere> Message-ID: References: <1236401580-5758-1-git-send-email-fweisbec@gmail.com> <1236401580-5758-2-git-send-email-fweisbec@gmail.com> <20090307074917.GA5749@nowhere> <20090309204748.GD5010@nowhere> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 44 On Mon, 9 Mar 2009, Frederic Weisbecker wrote: > On Mon, Mar 09, 2009 at 09:52:20AM -0400, Steven Rostedt wrote: > > > > On Sat, 7 Mar 2009, Frederic Weisbecker wrote: > > > + > > > + > > > +static atomic_t refcount; > > > + > > > +enum print_line_t > > > +print_syscall_enter(struct trace_iterator *iter, int flags) > > > +{ > > > + struct trace_seq *s = &iter->seq; > > > + struct trace_entry *ent = iter->ent; > > > + struct syscall_trace_enter *trace; > > > + enum syscall_trace_nr syscall; > > > + const struct syscall_trace_entry *entry; > > > + char *str = NULL; > > > + int i, ret; > > > + > > > + trace_assign_type(trace, ent); > > > + > > > + syscall = trace->nr; > > > + > > > + if (!syscall || syscall >= __SYSCALL_TRACE_END) > > > > You still need to print a "\n" otherwise the output of the next line > > will start on the current line. > > Are you sure? > This entry will be ignored. And the previous one did print a newline. > So the next one should not have any problem. Does this take over the printline? Otherwise we could be printing a header, (comm, timestamp, cpu, etc). -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/