Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753738AbZCJHh7 (ORCPT ); Tue, 10 Mar 2009 03:37:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752772AbZCJHhv (ORCPT ); Tue, 10 Mar 2009 03:37:51 -0400 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:56899 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752421AbZCJHhv (ORCPT ); Tue, 10 Mar 2009 03:37:51 -0400 Date: Tue, 10 Mar 2009 16:33:50 +0900 From: Paul Mundt To: Oskar Schirmer Cc: Andrew Morton , Johannes Weiner , David Howells , Russell King , Bryan Wu , Geert Uytterhoeven , Mike Frysinger , Greg Ungerer , linux-kernel@vger.kernel.org Subject: Re: [PATCH -v3] flat: fix data sections alignment Message-ID: <20090310073350.GH10393@linux-sh.org> Mail-Followup-To: Paul Mundt , Oskar Schirmer , Andrew Morton , Johannes Weiner , David Howells , Russell King , Bryan Wu , Geert Uytterhoeven , Mike Frysinger , Greg Ungerer , linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1520 Lines: 35 On Thu, Mar 05, 2009 at 06:00:59PM +0100, Oskar Schirmer wrote: > The flat loader uses an architecture's flat_stack_align() to align the > stack but assumes word-alignment is enough for the data sections. > > However, on the Xtensa S6000 we have registers up to 128bit width > which can be used from userspace and therefor need userspace stack and > data-section alignment of at least this size. > > This patch drops flat_stack_align() and uses the same alignment that > is required for slab caches, ARCH_SLAB_MINALIGN, or wordsize if it's > not defined by the architecture. > > It also fixes m32r which was obviously kaput, aligning an > uninitialized stack entry instead of the stack pointer. > > Signed-off-by: Oskar Schirmer > Signed-off-by: Johannes Weiner > Cc: David Howells > Cc: Russell King > Cc: Bryan Wu > Cc: Geert Uytterhoeven > Cc: Paul Mundt > Cc: Greg Ungerer > Cc: Mike Frysinger The updated version looks ok to me anyways, and it's certainly an improvement over defining the same alignment requirements all over the place. Acked-by: Paul Mundt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/