Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754677AbZCJMZf (ORCPT ); Tue, 10 Mar 2009 08:25:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752751AbZCJMZU (ORCPT ); Tue, 10 Mar 2009 08:25:20 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:35879 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752268AbZCJMZS (ORCPT ); Tue, 10 Mar 2009 08:25:18 -0400 Date: Tue, 10 Mar 2009 05:25:04 -0700 (PDT) Message-Id: <20090310.052504.186614357.davem@davemloft.net> To: tilman@imap.cc Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pebolle@tiscali.nl, hjlipp@web.de Subject: Re: [PATCH 1/2 v2] gigaset: return -ENOTTY for unimplemented functions From: David Miller In-Reply-To: <20090308-patch-01.tilman@imap.cc> References: <20090307-patch-01.tilman@imap.cc> <20090308-patch-01.tilman@imap.cc> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 21 From: Tilman Schmidt Date: Sun, 8 Mar 2009 16:23:13 +0100 (CET) > From: Paul Bolle > > A number of functions in the usb_gigaset module will return -EINVAL if > CONFIG_GIGASET_UNDOCREQ is not set. Make these return -ENOTTY as it's > more specific and it might make it easier to see (from userspace) why > these functions actually fail. > > Impact: some error return codes changed > > Signed-off-by: Paul Bolle > Signed-off-by: Tilman Schmidt Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/