Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755555AbZCJNjT (ORCPT ); Tue, 10 Mar 2009 09:39:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754900AbZCJNit (ORCPT ); Tue, 10 Mar 2009 09:38:49 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:60712 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754306AbZCJNis (ORCPT ); Tue, 10 Mar 2009 09:38:48 -0400 Date: Tue, 10 Mar 2009 21:38:28 +0800 From: Herbert Xu To: Geert Uytterhoeven Cc: Stephen Rothwell , Greg KH , linux-next@vger.kernel.org, Jason Baron , Greg Banks , Linux Kernel Development , Martin Schwidefsky Subject: Re: linux-next: driver-core tree build failure Message-ID: <20090310133828.GA14396@gondor.apana.org.au> References: <20090310192440.949884a1.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 23 On Tue, Mar 10, 2009 at 02:31:17PM +0100, Geert Uytterhoeven wrote: > > Why doesn't it work for dynamic_pr_debug()? Because fmt is expanded twice? > BTW, Martin: Is `#define pr_fmt(fmt) "%s: " fmt, __func__' a valid and > intended usage of your pr_fmt() infrastructure? I never liked this in the first place :) If anyone wants to debug this they can add whatever printks they want. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/