Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756519AbZCJOnR (ORCPT ); Tue, 10 Mar 2009 10:43:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755161AbZCJOnD (ORCPT ); Tue, 10 Mar 2009 10:43:03 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:33362 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754395AbZCJOnC (ORCPT ); Tue, 10 Mar 2009 10:43:02 -0400 Date: Tue, 10 Mar 2009 15:42:14 +0100 From: Ingo Molnar To: prasad@linux.vnet.ibm.com Cc: Andrew Morton , Linux Kernel Mailing List , Alan Stern , Roland McGrath Subject: Re: [patch 09/11] Cleanup HW Breakpoint registers before kexec Message-ID: <20090310144214.GG3850@elte.hu> References: <20090305043440.189041194@linux.vnet.ibm.com> <20090305044105.GJ17747@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090305044105.GJ17747@in.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 521 Lines: 19 * prasad@linux.vnet.ibm.com wrote: > + disable_debug_registers(); naming nit: please name them properly: breakpoints_disable(); breakpoints_enable(); new kernel APIs always get named left to right in ascending specificity order. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/