Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756896AbZCJTs4 (ORCPT ); Tue, 10 Mar 2009 15:48:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755112AbZCJTsc (ORCPT ); Tue, 10 Mar 2009 15:48:32 -0400 Received: from waldorf.bytemark.co.uk ([212.110.162.22]:41705 "EHLO waldorf.bytemark.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754536AbZCJTs3 (ORCPT ); Tue, 10 Mar 2009 15:48:29 -0400 X-Greylist: delayed 4328 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 Mar 2009 15:48:29 EDT Date: Tue, 10 Mar 2009 18:36:10 +0000 From: Andy Whitcroft To: Geert Uytterhoeven Cc: Joel Schopp , Randy Dunlap , Linux Kernel Development Subject: Re: checkpatch and pr_fmt()? Message-ID: <20090310183610.GE28243@shadowen.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 22 On Thu, Dec 18, 2008 at 05:24:06PM +0100, Geert Uytterhoeven wrote: > When using the recently introduced pr_fmt() infrastructure (commit > d091c2f58ba32029495a933b721e8e02fbd12caa, "Add 'pr_fmt()' format modifier to > pr_xyz macros."), checkpatch spits out the following annoying error: > > | ERROR: Macros with complex values should be enclosed in parenthesis > | +#define pr_fmt(fmt) "%s: " fmt, __func__ > > Unfortunately, adding parentheses is not a solution, as it creates illegal C > code. Yeah that one looks like something we should avoid. Fixed in my next update which can be tested here: http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/