Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757388AbZCJUBr (ORCPT ); Tue, 10 Mar 2009 16:01:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756382AbZCJUBi (ORCPT ); Tue, 10 Mar 2009 16:01:38 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:48124 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755603AbZCJUBh (ORCPT ); Tue, 10 Mar 2009 16:01:37 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Tue, 10 Mar 2009 21:01:08 +0100 (CET) From: Stefan Richter Subject: [PATCH 3/5] firewire: cdev: fix race of ioctl_send_request with bus reset To: linux1394-devel@lists.sourceforge.net cc: linux-kernel@vger.kernel.org In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 33 The bus reset handler concurrently frees client->device->node. Use device->node_id instead. This is equivalent to device->node->node_id while device->generation is current. Signed-off-by: Stefan Richter --- drivers/firewire/fw-cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/firewire/fw-cdev.c =================================================================== --- linux.orig/drivers/firewire/fw-cdev.c +++ linux/drivers/firewire/fw-cdev.c @@ -585,7 +585,7 @@ static int ioctl_send_request(struct cli return -EINVAL; } - return init_request(client, request, client->device->node->node_id, + return init_request(client, request, client->device->node_id, client->device->max_speed); } -- Stefan Richter -=====-==--= --== -=-=- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/