Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbZCKELb (ORCPT ); Wed, 11 Mar 2009 00:11:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750979AbZCKELU (ORCPT ); Wed, 11 Mar 2009 00:11:20 -0400 Received: from kroah.org ([198.145.64.141]:41180 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750851AbZCKELS (ORCPT ); Wed, 11 Mar 2009 00:11:18 -0400 Date: Tue, 10 Mar 2009 21:07:30 -0700 From: Greg KH To: Ming Lei Cc: Geert Uytterhoeven , Greg Kroah-Hartman , "James E.J. Bottomley" , Henrique de Moraes Holschuh , David Brownell , linux-next@vger.kernel.org, Linux Kernel Development , linux-scsi@vger.kernel.org, Linux/m68k Subject: Re: linux-next: NCR_700_detect warnings Message-ID: <20090311040730.GA29678@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2233 Lines: 47 On Wed, Mar 11, 2009 at 09:59:09AM +0800, Ming Lei wrote: > 2009/3/11 Geert Uytterhoeven : > > commit 76afea5b078d36ec080a75c29ff5a3fbc5774fee > > Author: Ming Lei > > Date: ? Fri Feb 6 23:40:12 2009 +0800 > > > > ? ?platform driver: fix incorrect use of 'platform_bus_type' with 'struct devic > > > > ? ?This patch fixes the bug reported in > > ? ? ? ?http://bugzilla.kernel.org/show_bug.cgi?id=11681. > > > > ? ?"Lots of device drivers register a 'struct device_driver' with > > ? ?the '.bus' member set to '&platform_bus_type'. This is wrong, > > ? ?since the platform_bus functions expect the 'struct device_driver' > > ? ?to be wrapped up in a 'struct platform_driver' which provides > > ? ?some additional callbacks (like suspend_late, resume_early). > > ? ?The effect may be that platform_suspend_late() uses bogus data > > ? ?outside the device_driver struct as a pointer pointer to the > > ? ?device driver's suspend_late() function or other hard to > > ? ?reproduce failures."(Lothar Wassmann) > > > > ? ?Signed-off-by: Ming Lei > > ? ?Acked-by: Henrique de Moraes Holschuh > > ? ?Acked-by: David Brownell > > ? ?Signed-off-by: Greg Kroah-Hartman > > > > This introduced the following warnings on m68k, as `dev' is now a > > `struct platform_device *' instead of a `struct device *': > > > > | drivers/scsi/a4000t.c:64: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type > > | drivers/scsi/mvme16x_scsi.c:67: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type > > | drivers/scsi/bvme6000_scsi.c:61: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type > > > > I think the below is missing (untested on real hardware)? > > Yes, you are correct. It is really missed. Great, Geert, care to resend with a signed-off-by: so I can apply this? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/