Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755421AbZCKKnh (ORCPT ); Wed, 11 Mar 2009 06:43:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753841AbZCKKn2 (ORCPT ); Wed, 11 Mar 2009 06:43:28 -0400 Received: from an-out-0708.google.com ([209.85.132.243]:36217 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753597AbZCKKn1 (ORCPT ); Wed, 11 Mar 2009 06:43:27 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:message-id:from:to:cc:subject:user-agent:mime-version :content-type; b=FFcnYsdwVUOW2eN4psP1bqrQUFefv9Wu80RCHpe2oY3Lt+slDfjAJQgvyYr8PnH2xz JIZTaajum9Om7kdSZ3uEX7+fcGN0gqpRakjPOU4ruYMYJxPDU3AXdkuf2MGgKtn609Zx Sm9Jiq/kZv7wgdcgfSuQoq6gf5Vfl4lD7ID3U= Date: Wed, 11 Mar 2009 11:43:37 +0100 Message-ID: <87mybscpba.wl%vmayatsk@redhat.com> From: Vitaly Mayatskikh To: linux-kernel@vger.kernel.org Cc: Linus Torvalds Subject: [PATCH] vscnprintf/scnprintf return incorrent len User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/22.3 Mule/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1839 Lines: 53 (v)scnprintf says it should return 0 when size is 0, but doesn't do so. Also size_t is unsigned, it can't be less then 0. Fix the code and comments. diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 0fbd012..8e75c7e 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -947,7 +947,7 @@ EXPORT_SYMBOL(vsnprintf); * @args: Arguments for the format string * * The return value is the number of characters which have been written into - * the @buf not including the trailing '\0'. If @size is <= 0 the function + * the @buf not including the trailing '\0'. If @size is == 0 the function * returns 0. * * Call this function if you are already dealing with a va_list. @@ -958,7 +958,8 @@ EXPORT_SYMBOL(vsnprintf); int vscnprintf(char *buf, size_t size, const char *fmt, va_list args) { int i; - + if (!size) + return 0; i=vsnprintf(buf,size,fmt,args); return (i >= size) ? (size - 1) : i; } @@ -998,7 +999,7 @@ EXPORT_SYMBOL(snprintf); * @...: Arguments for the format string * * The return value is the number of characters written into @buf not including - * the trailing '\0'. If @size is <= 0 the function returns 0. + * the trailing '\0'. If @size is == 0 the function returns 0. */ int scnprintf(char * buf, size_t size, const char *fmt, ...) @@ -1006,6 +1007,8 @@ int scnprintf(char * buf, size_t size, const char *fmt, ...) va_list args; int i; + if (!size) + return 0; va_start(args, fmt); i = vsnprintf(buf, size, fmt, args); va_end(args); -- wbr, Vitaly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/