DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=uoJbWi8qYLT+CB2NSiSdXyXv7jajza7azi9k0ITtQak86UVDrEW+phxrkgnuQ4dwD1
         U5XpIvbC7E+BMajDRc8BtwIJcnCrteh44j7dwj8ghp5TPEGja1ygsdeXRfUZEYAnOzN9
         BeYAyyg1f+avy7Po9kI03eVa4NAC/ALEKIq6s=
MIME-Version: 1.0
In-Reply-To: <20090311201337.GI25995@parisc-linux.org>
References: <20090311043659.GC25995@parisc-linux.org>
	 <alpine.LFD.2.00.0903111220200.32478@localhost.localdomain>
	 <20090311201337.GI25995@parisc-linux.org>
Date: Wed, 11 Mar 2009 13:36:05 -0700
Message-ID: <86802c440903111336v7b5c3e3jc5bb3afd9da8f42e@mail.gmail.com>
Subject: Re: [GIT PULL] PCI fixes for 2.6.29
From: Yinghai Lu <yinghai@kernel.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, linux-pci@vger.kernel.org,
       linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1367
Lines: 36

On Wed, Mar 11, 2009 at 1:13 PM, Matthew Wilcox <matthew@wil.cx> wrote:
> On Wed, Mar 11, 2009 at 12:22:56PM -0700, Linus Torvalds wrote:
>> On Tue, 10 Mar 2009, Matthew Wilcox wrote:
>> > These are the PCI fixes that have been piling up for the last week while
>> > Jesse's been on vacation. ?I don't think there's anything questionable
>> > here. ?All the patches have been posted to linux-pci.
>>
>> Grrr. It doesn't even compile cleanly:
>>
>> drivers/pci/quirks.c: In function ?ht_check_msi_mapping?:
>> drivers/pci/quirks.c:2142: warning: ?return? with no value, in function returning non-void
>>
>> and yes, it's a real bug.
>
> Agreed, it's a real bug. ?I also think it should return 0, but I want
> Prakash to verify that, since I don't have a system of this nature.
>
> I wish this warning were an error. ?According to the GCC docs,
> -Werror=return-type should do this, but it seems to have no effect.
>
>> I'm not happy.
>
> Me neither. ?I'm sorry I didn't catch the warning.
>

please don't use that one. and use "pci: don't disable too many HT MSI
mapping -v4" instead

http://lkml.org/lkml/2009/3/5/458

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/