Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753476AbZCKVoX (ORCPT ); Wed, 11 Mar 2009 17:44:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751905AbZCKVoO (ORCPT ); Wed, 11 Mar 2009 17:44:14 -0400 Received: from www.tglx.de ([62.245.132.106]:41319 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbZCKVoN (ORCPT ); Wed, 11 Mar 2009 17:44:13 -0400 Date: Wed, 11 Mar 2009 22:42:09 +0100 (CET) From: Thomas Gleixner To: "Rafael J. Wysocki" cc: Ingo Molnar , pm list , LKML , Linus Torvalds , "Eric W. Biederman" , Benjamin Herrenschmidt , Jeremy Fitzhardinge , Len Brown , Jesse Barnes , Frans Pop , =?ISO-8859-15?Q?Arve_Hj=F8nnev=E5g?= Subject: Re: [PATCH 1/10] PM: Rework handling of interrupts during suspend-resume (rev. 5) In-Reply-To: <200903112159.21166.rjw@sisk.pl> Message-ID: References: <200902221837.49396.rjw@sisk.pl> <200903111036.02482.rjw@sisk.pl> <200903112159.21166.rjw@sisk.pl> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1407 Lines: 36 On Wed, 11 Mar 2009, Rafael J. Wysocki wrote: > On Wednesday 11 March 2009, Thomas Gleixner wrote: > > > +EXPORT_SYMBOL_GPL(suspend_device_irqs); > > > > I'm not too enthusiastic about this open coded implementation of > > disable_irq() with slightly different semantics. > > The difference in semantics is important IMO, otherwise I woulndn't have > done that. In particular, IMO, the condition should be under the spinlock IMO > and I'd rather not synchronize all interrupts we don't really disable here. I don't say that the difference is not relevant. But the code is almost the same and disable_irq() could have the sync_irq optimization as well. > > Can we please move the fiddling with desc->* into > > kernel/irq/manage.c and share the code there ? > > Can you please discuss that with Ingo? I moved that from manage.c at his > request. Hmrpf. Will do. I just want to avoid that we have scattered functions which deal with the guts of the irq code all over the place. I'm fine with your loop in irq/pm.c, but the actual handling of the irq internals should remain in manage.c. I'll have a closer look how to solve this. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/