Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755531AbZCLEeT (ORCPT ); Thu, 12 Mar 2009 00:34:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751247AbZCLEeG (ORCPT ); Thu, 12 Mar 2009 00:34:06 -0400 Received: from yx-out-2324.google.com ([74.125.44.30]:20147 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754AbZCLEeE convert rfc822-to-8bit (ORCPT ); Thu, 12 Mar 2009 00:34:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=qng/y12lsej/G1TgGmEcAukpj/IEnQra+RZQ3OeMIc73biTXOKoJ98gR5qkhk5ibGq LxbUkTyU7XvWp0ktIELyS5mYUDt0pQLXl74pH5zvisVqhHo8hBmSGckElhLWsDglXcKC 6KLk3PTgaA5KhaqHz+yY9e9ULbKpNw+fnf/hY= MIME-Version: 1.0 In-Reply-To: <1236832241.21146.12.camel@dy> References: <1236756563-20633-1-git-send-email-graff.yang@gmail.com> <8bd0f97a0903110057x46cb2aa9p43dd8e12a28be67a@mail.gmail.com> <7d86d44a0903110256t11edeff5qfd21055ef047dc2a@mail.gmail.com> <8bd0f97a0903110343m1f2f01catbc6cd54ecce91db9@mail.gmail.com> <1236831455.21146.7.camel@dy> <8bd0f97a0903112123j60eab672m16177581c959453b@mail.gmail.com> <1236832241.21146.12.camel@dy> Date: Thu, 12 Mar 2009 00:34:02 -0400 Message-ID: <8bd0f97a0903112134m52a8faddp69926cb1281f5ce5@mail.gmail.com> Subject: Re: [PATCH] [net/irda]: new Blackfin on-chip SIR IrDA driver From: Mike Frysinger To: gyang Cc: graff yang , samuel@sortiz.org, irda-users@lists.sourceforge.net, linux-kernel@vger.kernel.org, cooloney@kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2101 Lines: 49 On Thu, Mar 12, 2009 at 00:30, gyang wrote: > On Thu, 2009-03-12 at 00:23 -0400, Mike Frysinger wrote: >> On Thu, Mar 12, 2009 at 00:17, gyang wrote: >> > On Wed, 2009-03-11 at 06:43 -0400, Mike Frysinger wrote: >> >> On Wed, Mar 11, 2009 at 05:56, graff yang wrote: >> >> > On Wed, Mar 11, 2009 at 3:57 PM, Mike Frysinger wrote: >> >> >> On Wed, Mar 11, 2009 at 03:29,   wrote: >> >> >>> +static int __devinit bfin_sir_probe(struct platform_device *pdev) >> >> >>> +{ >> >> >>> +       struct net_device *dev; >> >> >>> +       struct bfin_sir_self *self; >> >> >>> +       unsigned int baudrate_mask; >> >> >>> +       struct bfin_sir_port *sir_port; >> >> >>> +       int err; >> >> >>> + >> >> >>> +       err = peripheral_request_list(per[pdev->id], DRIVER_NAME); >> >> >> >> >> >> what if pdev->id is set to 12512 ? >> >> > >> >> > The pdev->id is defined in board files, for example, uart0 should be 0. >> >> >> >> so ?  what's to stop the user from setting it to 12415 ?  the driver >> >> must sanity check these things.  you can never assume platform dev >> >> resources always have valid pointers and valid values. >> > >> > How about to limit the pdev->id to be 0,1,2,3 ? >> > I can extend the per to be >> > static const unsigned short per[][4] = { >> >        {P_UART0_RX, P_UART0_TX, 0, 0}, >> >        {P_UART1_RX, P_UART1_TX, 0, 1}, >> >        {P_UART2_RX, P_UART2_TX, 0, 2}, >> >        {P_UART3_RX, P_UART3_TX, 0, 3}, >> > }; >> > >> > then check (pdev->id >= 0 && pdev->id < ARRAY_SIZE(per) && >> > per[pdev->id][3] == pdev->id) >> >> the last check is redundant.  the first two should be added. > > I'm afraid of some cases such as uart0 uses id 1, will cause driver not > work, and not any warning message. then the call to peripheral request would fail as expected -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/