Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755973AbZCLEfi (ORCPT ); Thu, 12 Mar 2009 00:35:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752847AbZCLEf3 (ORCPT ); Thu, 12 Mar 2009 00:35:29 -0400 Received: from e28smtp01.in.ibm.com ([59.145.155.1]:44275 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504AbZCLEf2 (ORCPT ); Thu, 12 Mar 2009 00:35:28 -0400 Date: Thu, 12 Mar 2009 10:05:18 +0530 From: Balbir Singh To: Bharata B Rao Cc: KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, Balaji Rao , Dhaval Giani , Li Zefan , Paul Menage , Andrew Morton , Ingo Molnar , Peter Zijlstra Subject: Re: [RFC PATCH] cpuacct: per-cgroup utime/stime statistics - v1 Message-ID: <20090312043518.GH23583@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20090310124208.GC3902@in.ibm.com> <20090311093812.298a0b21.kamezawa.hiroyu@jp.fujitsu.com> <20090311153434.GB16769@balbir.in.ibm.com> <20090312042951.GA3344@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20090312042951.GA3344@in.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1188 Lines: 31 * Bharata B Rao [2009-03-12 09:59:51]: > On Wed, Mar 11, 2009 at 09:04:34PM +0530, Balbir Singh wrote: > > * KAMEZAWA Hiroyuki [2009-03-11 09:38:12]: > > > > > BTW, I'm not sure but don't we need special handling if > > > CONFIG_VIRT_CPU_ACCOUNTING=y ? > > > > Good point. Bharata, with CONFIG_VIRT_CPU_ACCOUNTING, utime and stime > > is accounted for within the architecture. > > True, but as I replied to Kamezawa in the other thread, these > architectures are still dependent on generic implementations of > account_{system,user}_time() which feed to per-process and system-wide > accounting. And this is where we have hooks for per-cgroup accounting. Fair enough... > So I don't see why we need to handle these archs specially. Do I miss > something ? May be we should cc the patch to linux-arch as well to make sure we handled all architectures correctly. -- Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/