Date: Thu, 12 Mar 2009 18:58:07 +0100
From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Rusty Russell <rusty@rustcorp.com.au>
CC: Dmitry Adamushko <dmitry.adamushko@gmail.com>, Ingo Molnar <mingo@elte.hu>,
       linux-kernel@vger.kernel.org
Subject: Re: x86-microcode: get rid of set_cpus_allowed()
Message-ID: <20090312175807.GJ20716@alberich.amd.com>
References: <1236627539.5168.48.camel@earth> <200903111714.37444.rusty@rustcorp.com.au> <20090312174010.GI20716@alberich.amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
In-Reply-To: <20090312174010.GI20716@alberich.amd.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2000
Lines: 59

On Thu, Mar 12, 2009 at 06:40:10PM +0100, Andreas Herrmann wrote:
> On Wed, Mar 11, 2009 at 07:44:37AM +0100, Rusty Russell wrote:
> > On Tuesday 10 March 2009 06:08:59 Dmitry Adamushko wrote:
> > > 
> > > Hi,
> > > 
> > > 
> > > here is a possible candidate for Rusty's cpumask-refactored series.
> > > Note the [*] remark below though.
> > 
> > Ah, OK, I'll drop my version then (below) in favor of this, and will
> > push to Ingo with the others if he doesn't take it directly.
> 
> Sorry guys -- for the late reply --
> but I missed Dmitry's mail due to some silly mail filtering and had to
> restore his mail ...
> 
> Now I've tested both patches and both seem to reliably prevent
> microcode updates on CPU1 and CPU2 of an Phenom X3 after
> suspend/resume. (Just CPU0 was updated.)
> 
> Then I've tested mainline kernel w/o your patches and I've observed
> similar problems. I've seen that sometimes ucode of CPU0 was not
> updated and sometimes CPU1 and CPU2 were not updated.
> 
> I'll look into this asap.

Some further testing seem to indicate that suspend/resume does not
work when I have done CPU hotplug before.

During today's tests I did:

(1) set offline/online CPU 1 and 2
(2) perform suspend/resume afterwards

After that microcode update failed on some CPUs when performing
suspend/resume. (When skipping step 1, microcode update during
suspend/resume works.)

Looks strange, but should be debuggable.


Regards,

Andreas

-- 
Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. M?nchen, Germany
 Research | Gesch?ftsf?hrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis M?nchen
  (OSRC)  | Registergericht M?nchen, HRB Nr. 43632


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/