Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755198AbZCLTBE (ORCPT ); Thu, 12 Mar 2009 15:01:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752130AbZCLTAs (ORCPT ); Thu, 12 Mar 2009 15:00:48 -0400 Received: from mail.fieldses.org ([141.211.133.115]:38497 "EHLO pickle.fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbZCLTAr (ORCPT ); Thu, 12 Mar 2009 15:00:47 -0400 Date: Thu, 12 Mar 2009 15:00:39 -0400 To: "Serge E. Hallyn" Cc: Igor Zhbanov , linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, neilb@suse.de, Trond.Myklebust@netapp.com, David Howells , James Morris Subject: Re: VFS, NFS security bug? Should CAP_MKNOD and CAP_LINUX_IMMUTABLE be added to CAP_FS_MASK? Message-ID: <20090312190039.GA6901@fieldses.org> References: <20090311232356.GP13540@fieldses.org> <20090312161047.GA15209@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090312161047.GA15209@us.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) From: "J. Bruce Fields" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 30 On Thu, Mar 12, 2009 at 11:10:47AM -0500, Serge E. Hallyn wrote: > Quoting J. Bruce Fields (bfields@fieldses.org): > > On Wed, Mar 11, 2009 at 03:53:34PM +0300, Igor Zhbanov wrote: > > > Hello! > > > > > > It seems that CAP_MKNOD and CAP_LINUX_IMMUTABLE were forgotten to be > > > added to CAP_FS_MASK_B0 in linux-2.6.x and to CAP_FS_MASK in > > > linux-2.4.x. Both capabilities affects file system and can be > > > considered file system capabilities. > > > > Sounds right to me--I'd expect rootsquash to guarantee that new device > > nodes can't be created from the network. Cc'ing random people from the > > git log for include/linux/capability.h in hopes they can help. > > Yeah it seems reasonable. If it is, then does that mean that we > also need CAP_SYS_ADMIN (to write selinux labels) and CAP_SETFCAP > (to set file capabilities) as well? For nfsd at least we should be droppping anything that concerns the filesystem and would normally require root privileges. We need to trace up through the users of CAP_FS_SET and figure out what other users need. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/