Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756590AbZCLXvz (ORCPT ); Thu, 12 Mar 2009 19:51:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752287AbZCLXvm (ORCPT ); Thu, 12 Mar 2009 19:51:42 -0400 Received: from wa-out-1112.google.com ([209.85.146.176]:14951 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbZCLXvl (ORCPT ); Thu, 12 Mar 2009 19:51:41 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=Xuj7Lmtlya8hhyTF+xqwXf1wH/pWUaAHkT3rtV/vsa+1099A4lbxa2ojslimjnIHPw 8SeDdBPQjYAWOREQOLgmrUfJwylCQoVKGv5jdIXR7fsFXpivwZ9PCD/mR+xZK+r3ulXO ShlDVf8I8XcFNcvHQyxVzPIhjYukfdzOrybeA= Subject: Re: [PROBLEM]: potential unaligned memory access in drivers/usb/gadget/rndis.c From: Harvey Harrison To: Andrew Morton Cc: yann.poupet@free.fr, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <20090311235119.f4609775.akpm@linux-foundation.org> References: <3848726.1723791236775868071.JavaMail.root@spooler2-g27.priv.proxad.net> <20090311235119.f4609775.akpm@linux-foundation.org> Content-Type: text/plain Date: Thu, 12 Mar 2009 16:51:37 -0700 Message-Id: <1236901897.4036.1.camel@brick> Mime-Version: 1.0 X-Mailer: Evolution 2.25.92 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1161 Lines: 33 On Wed, 2009-03-11 at 23:51 -0700, Andrew Morton wrote: > Maybe the below fixed this? afacit it is queued for 2.6.30 in the > net-next tree: > > commit 35c26c2cf6a6a2d1c48add732d8ba002bd90784c > Author: Harvey Harrison > AuthorDate: Sat Feb 14 22:56:56 2009 -0800 > Commit: David S. Miller > CommitDate: Sat Feb 14 22:56:56 2009 -0800 > > rndis: remove private wrapper of __constant_cpu_to_le32 > > Use cpu_to_le32 directly as it handles constant folding now, replace direct > uses of __constant_cpu_to_{endian} as well. > > Signed-off-by: Harvey Harrison > Acked-by: David Brownell > Signed-off-by: David S. Miller > Doubtful, this patch should be a no-op, any alignment problems that existed before will still be there. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/