Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758188AbZCMHSa (ORCPT ); Fri, 13 Mar 2009 03:18:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756801AbZCMHP2 (ORCPT ); Fri, 13 Mar 2009 03:15:28 -0400 Received: from mail-gx0-f167.google.com ([209.85.217.167]:43911 "EHLO mail-gx0-f167.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756759AbZCMHP0 convert rfc822-to-8bit (ORCPT ); Fri, 13 Mar 2009 03:15:26 -0400 MIME-Version: 1.0 In-Reply-To: <200903122243.27452.rjw@sisk.pl> References: <200902221837.49396.rjw@sisk.pl> <200903121436.21504.rjw@sisk.pl> <200903122243.27452.rjw@sisk.pl> Date: Thu, 12 Mar 2009 23:15:22 -0800 Message-ID: Subject: Re: [update, rev. 6] Re: [PATCH 1/10] PM: Rework handling of interrupts during suspend-resume (rev. 5) From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: "Rafael J. Wysocki" Cc: Thomas Gleixner , Ingo Molnar , pm list , LKML , Linus Torvalds , "Eric W. Biederman" , Benjamin Herrenschmidt , Jeremy Fitzhardinge , Len Brown , Jesse Barnes , Frans Pop Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 18 On Thu, Mar 12, 2009 at 1:43 PM, Rafael J. Wysocki wrote: > > +void __disable_irq(struct irq_desc *desc, unsigned int irq, bool suspend) > +{ > + ? ? ? if (suspend) { > + ? ? ? ? ? ? ? if (desc->action && (desc->action->flags & IRQF_TIMER)) > + ? ? ? ? ? ? ? ? ? ? ? return; Don't you want "(!desc->action || ..." here to avoid enabling unused interrupts on resume? -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/