Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758217AbZCMPdW (ORCPT ); Fri, 13 Mar 2009 11:33:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751550AbZCMPdM (ORCPT ); Fri, 13 Mar 2009 11:33:12 -0400 Received: from trinity.fluff.org ([89.16.178.74]:33489 "EHLO trinity.fluff.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbZCMPdM (ORCPT ); Fri, 13 Mar 2009 11:33:12 -0400 Date: Fri, 13 Mar 2009 15:32:56 +0000 From: Ben Dooks To: Daniel Mack Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Dooks Subject: Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device Message-ID: <20090313153255.GG6295@trinity.fluff.org> References: <1236955851-14763-1-git-send-email-daniel@caiaq.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1236955851-14763-1-git-send-email-daniel@caiaq.de> X-Disclaimer: These are my views alone. X-URL: http://www.fluff.org/ User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1808 Lines: 62 On Fri, Mar 13, 2009 at 03:50:51PM +0100, Daniel Mack wrote: > This patch adds support to the ax88796 ethernet driver to take IRQ flags > given by the platform_device definition. > > The patch depends on the platform_get_irq_flags() function which I added > in a patch posted here: > > http://lkml.org/lkml/2009/3/13/267 > > Signed-off-by: Daniel Mack > Cc: Ben Dooks Acked-by: Ben Dooks > --- > drivers/net/ax88796.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c > index a4eb6c4..728e17c 100644 > --- a/drivers/net/ax88796.c > +++ b/drivers/net/ax88796.c > @@ -93,6 +93,7 @@ struct ax_device { > > unsigned char running; > unsigned char resume_open; > + unsigned int irqflags; > > u32 reg_offsets[0x20]; > }; > @@ -474,7 +475,8 @@ static int ax_open(struct net_device *dev) > > dev_dbg(&ax->dev->dev, "%s: open\n", dev->name); > > - ret = request_irq(dev->irq, ax_ei_interrupt, 0, dev->name, dev); > + ret = request_irq(dev->irq, ax_ei_interrupt, ax->irqflags, > + dev->name, dev); > if (ret) > return ret; > > @@ -856,6 +858,7 @@ static int ax_probe(struct platform_device *pdev) > goto exit_mem; > } > dev->irq = ret; > + ax->irqflags = platform_get_irq_flags(pdev, 0); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > if (res == NULL) { > -- > 1.6.2 > -- -- Ben Q: What's a light-year? A: One-third less calories than a regular year. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/