Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758974AbZCMQyE (ORCPT ); Fri, 13 Mar 2009 12:54:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754903AbZCMQxw (ORCPT ); Fri, 13 Mar 2009 12:53:52 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:37689 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754180AbZCMQxv convert rfc822-to-8bit (ORCPT ); Fri, 13 Mar 2009 12:53:51 -0400 From: "Rafael J. Wysocki" To: Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= Subject: Re: [update, rev. 6] Re: [PATCH 1/10] PM: Rework handling of interrupts during suspend-resume (rev. 5) Date: Fri, 13 Mar 2009 17:53:37 +0100 User-Agent: KMail/1.11.1 (Linux/2.6.29-rc7-tst; KDE/4.2.1; x86_64; ; ) Cc: Thomas Gleixner , Ingo Molnar , pm list , LKML , Linus Torvalds , "Eric W. Biederman" , Benjamin Herrenschmidt , Jeremy Fitzhardinge , Len Brown , Jesse Barnes , Frans Pop References: <200902221837.49396.rjw@sisk.pl> <200903122243.27452.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200903131753.39076.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 21 On Friday 13 March 2009, Arve Hj?nnev?g wrote: > On Thu, Mar 12, 2009 at 1:43 PM, Rafael J. Wysocki wrote: > > > > +void __disable_irq(struct irq_desc *desc, unsigned int irq, bool suspend) > > +{ > > + if (suspend) { > > + if (desc->action && (desc->action->flags & IRQF_TIMER)) > > + return; > > Don't you want "(!desc->action || ..." here to avoid enabling unused > interrupts on resume? Hmm, good idea, thanks. Best, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/