Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763375AbZCNBc5 (ORCPT ); Fri, 13 Mar 2009 21:32:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753841AbZCNBUe (ORCPT ); Fri, 13 Mar 2009 21:20:34 -0400 Received: from kroah.org ([198.145.64.141]:35079 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753228AbZCNBUR (ORCPT ); Fri, 13 Mar 2009 21:20:17 -0400 X-Mailbox-Line: From gregkh@mini.kroah.org Fri Mar 13 18:10:36 2009 Message-Id: <20090314011036.569707036@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Fri, 13 Mar 2009 18:10:12 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , Jake Edge , Eugene Teo , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Clemens Ladisch , Takashi Iwai Subject: [patch 035/114] sound: usb-audio: fix uninitialized variable with M-Audio MIDI interfaces References: <20090314010937.416083662@mini.kroah.org> Content-Disposition: inline; filename=sound-usb-audio-fix-uninitialized-variable-with-m-audio-midi-interfaces.patch In-Reply-To: <20090314011649.GA26170@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 32 2.6.28-stable review patch. If anyone has any objections, please let us know. ------------------ From: Clemens Ladisch commit e156ac4c571e3be741bc411e58820b74a9295c72 upstream. Fix the snd_usbmidi_create_endpoints_midiman() function, which forgot to set the out_interval member of the endpoint info structure for Midiman/ M-Audio devices. Since kernel 2.6.24, any non-zero value makes the driver use interrupt transfers instead of bulk transfers. With EHCI controllers, these random interval values result in unbearably large latencies for output MIDI transfers. Signed-off-by: Clemens Ladisch Reported-by: David Tested-by: David Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/usbmidi.c | 1 + 1 file changed, 1 insertion(+) --- a/sound/usb/usbmidi.c +++ b/sound/usb/usbmidi.c @@ -1628,6 +1628,7 @@ static int snd_usbmidi_create_endpoints_ } ep_info.out_ep = get_endpoint(hostif, 2)->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK; + ep_info.out_interval = 0; ep_info.out_cables = endpoint->out_cables & 0x5555; err = snd_usbmidi_out_endpoint_create(umidi, &ep_info, &umidi->endpoints[0]); if (err < 0) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/